-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update plugin to minimum Nx v16.8.1 #205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As well as the lockfile changed error, I'm now getting e2e errors where Nx says it cant find projects. Beyond annoying now.
Seems the Nx Daemon is unhelpful in e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated plugin workspace to Nx version 16.8.1
This was a key Nx release that introduced the
as-provided
andderived
concepts for project name/directory.I wanted to start the plugin compatibility roadmap here rather than just jump to the latest Nx, since there may be plugin users still using Nx 16.x and I want to give those users incremental Nx version updates of the plugin.
Plugin Changes:
app
andfunction
generators now support the--projectNameAndRootFormat=[as-provided|derived]
option, to match Nx's own plugins. This is only temporary until Nx 19, when all generators will useas-provided
.as-provided
this should make the plugin compatible with those scenarios.e2e Changes:
--bundler=tsc
option instead of deprecated--buildable
LOCK_FILE_CHANGED
errors during e2e steps that installed new packages (eg.@nx/js:build
)CI
environment var for local e2e tests.ensureNxProject()
function does seem to runnpm install
at first as well aspnpm install
so the e2e project workspace contains bothpackage-lock.json
andpnpm-lock.yaml
files which is odd.npm
. So I'm not sure how the e2e runner determines ifnpm
orpnpm
gets used - either hard coded, or inferred from the e2e host project. Dont really care. 😅