Add support and tests for individual AOAI keys #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonkurtz-MSFT I think it's fine for packages to support multiple forms of credentials. We avoid keys in our azd template samples since we provide the full infrastructure to create the RBAC roles, but I know devs sometimes use keys in other codebases. |
simonkurtz-MSFT
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
@jjczopek, take a look at this PR, please. When I remove the identity and use real API keys for each of my backends, I can see successful requests. I also see failing requests for incorrect keys. Would love to know what your experience is, please.
@pamelafox, while I don't love adding individual API key support and much prefer managed identities instead, I realize the use case. I'm very interested in your thoughts.
The PR also externalizes test harness configuration into a new
config.py.Outstanding item is to update the Package Readme.
This is a non-breaking feature addition. The package version will move from
1.0.9to1.1.0.