Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include function to get cfitsio version #379

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Include function to get cfitsio version #379

merged 3 commits into from
Dec 31, 2024

Conversation

simonrw
Copy link
Owner

@simonrw simonrw commented Dec 30, 2024

We provide an example to print the cfitiso version.

Note: this is designed to work on versions 3+ so we don't support the semver patch version (yet).

We also add running this example before each test that uses features so that we can debug in the future cfitsio versions.

@simonrw simonrw self-assigned this Dec 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 89.0%. Comparing base (f306c58) to head (1001232).

Files with missing lines Patch % Lines
fitsio-sys/src/lib.rs 0.0% 12 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
fitsio-sys/src/lib.rs 0.0% <0.0%> (ø)

@simonrw simonrw force-pushed the print-fitsio-version branch from 18749da to ee31670 Compare December 30, 2024 22:01
Note: currently only works on cfitsio >= v4.0.0 since versions previous
to this don't include the `CFITSIO_MICRO` symbol used in this function.

TODO: update this
@simonrw simonrw force-pushed the print-fitsio-version branch from ee31670 to 76eb6b9 Compare December 31, 2024 23:09
This is mostly useful for CI
@simonrw simonrw marked this pull request as ready for review December 31, 2024 23:24
@simonrw simonrw merged commit 1904d1d into main Dec 31, 2024
11 checks passed
@simonrw simonrw deleted the print-fitsio-version branch December 31, 2024 23:26
This was referenced Dec 31, 2024
simonrw added a commit that referenced this pull request Jan 2, 2025
## 🤖 New release
* `fitsio`: 0.21.6 -> 0.21.7 (✓ API compatible changes)
* `fitsio-sys`: 0.5.4 -> 0.5.5 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `fitsio`
<blockquote>

##
[0.21.7](fitsio-v0.21.6...fitsio-v0.21.7)
- 2025-01-02

### Other

- Include function to get cfitsio version
([#379](#379))
- Fix macos tests
([#380](#380))
</blockquote>

## `fitsio-sys`
<blockquote>

##
[0.5.5](fitsio-sys-v0.5.4...fitsio-sys-v0.5.5)
- 2025-01-02

### Other

- Simplify build.rs of fitsio-sys
([#377](#377))
- Include function to get cfitsio version
([#379](#379))
- *(deps)* update bindgen requirement from 0.70 to 0.71 in /fitsio-sys
in the cargo-packages group (#372)
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants