Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft module level defaults #35

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Draft module level defaults #35

wants to merge 2 commits into from

Conversation

dpole
Copy link
Contributor

@dpole dpole commented May 19, 2020

Allow for module-level defaults. E.g. to fix the frequencies for all the SED classes you'll create from fgspectra.frequency, now you can do

fgspectra.frequency.defaults = {'nu': np.arange(10)}

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #35 into master will increase coverage by 3.09%.
The diff coverage is 64.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   64.01%   67.10%   +3.09%     
==========================================
  Files           4        4              
  Lines         289      304      +15     
==========================================
+ Hits          185      204      +19     
+ Misses        104      100       -4     
Impacted Files Coverage Δ
fgspectra/frequency.py 81.53% <ø> (-0.28%) ⬇️
fgspectra/power.py 61.29% <33.33%> (-2.51%) ⬇️
fgspectra/model.py 83.33% <100.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9fe8e...aa8ce23. Read the comment docs.

@dpole
Copy link
Contributor Author

dpole commented May 19, 2020

I've used this new functionality in test_model.py. As you can see now ell is not specified for every model but once for all at the beginning

fgp.defaults = {'ell': np.array([2000])}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants