Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing beam chromaticity in mflike #59

Merged
merged 8 commits into from
Sep 26, 2024
Merged

Implementing beam chromaticity in mflike #59

merged 8 commits into from
Sep 26, 2024

Conversation

sgiardie
Copy link
Collaborator

Linked to PR#76 in LAT_MFLike

@beringueb
Copy link
Collaborator

I have checked the implementation as best as I could and it seems to indeed compute what we are interested in without breaking backward compatibility when beam chromaticity is not included.
@sgiardie and I both agree that FactorizedCrossSpectrumTE() could be renamed to make it more generic, but due to lack of ideas we'll keep it as it is for now. If other use cases arise, we can rename it in a future releasre (with proper aliasing to preserve backward compatibility).

@beringueb beringueb merged commit de43859 into main Sep 26, 2024
6 checks passed
@beringueb beringueb deleted the dev_beam branch September 26, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants