Visibility update #33
Open
+384
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced 'argparse' support to allow setting the visibility type when populating the database. - The visibility argument defaults to "collaboration" if not specified. - This visibility is applied directly during the 'create_product' call.
- Implemented set-visibility commands in cli.py to manage visibility for products and collections. - These commands interact with the respective visibility endpoints, allowing users to modify visibility settings directly from the CLI. Usage: - henry product set-visibility <product-id> <visibility> - henry collection set-visibility <collection-id> <visibility>
…ollections Provides an interface to modify the visibility of collections (public, collaboration, private) via calls to set_visibility in hippoclient/product.py.
…nd UpdateProductRequest
…d in product service layer
…t_visibility in the client layer
…d added the check_visibility_access
…kick in version changes when product/collection visibility has changed
JBorrow
reviewed
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces visibility management features in the code: