Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev compile for when M chip exists. #262

Closed
wants to merge 3 commits into from

Conversation

iparask
Copy link
Member

@iparask iparask commented Jul 11, 2024

This is more for when someone installs pixell on a new Macbook for development. It does not replace the wheels that exist.

Meson will now check if the system is a MacBook with an M chip. When OpenMP is not found it will just compile without it. If the system is Linux or Intel based Mac it will error out. The same with windows because they are not supported.

If OpenMP is found, then all is well and it will continue as expected.

It also fixes another incompatibility error because of clang.

@iparask iparask requested review from msyriac and JBorrow July 11, 2024 15:56
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.79%. Comparing base (1f52ada) to head (8d05e6d).
Report is 22 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   38.79%   38.79%           
=======================================
  Files          28       28           
  Lines        9799     9799           
=======================================
  Hits         3802     3802           
  Misses       5997     5997           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iparask iparask changed the base branch from meson-build-system to master July 15, 2024 23:09
@iparask iparask closed this Nov 8, 2024
@iparask iparask deleted the gp/meson-build-system/m_chips branch November 8, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant