Update from development repo #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stall more convenient. It's optional, and people who don't use it shouldn't be impacted. Also made the temporary linkables used as a dependency for the cython compile static instead of shared, since they are just an intermediate step towards the final shared library. That way we don't end up with too many similar but confusingly named shared libraries that depend on each other, e.g. lib_cmisc_shared.so being a dependency of the cmisc.so python extension
…. More general nditer. Disk overlap stuff. Nufft interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some chance of breakage with this update. It changes the mode keyword of utils.interpol and other functions that use it, such as enmap.at, enmap.project, etc.
modeused to control the boundary conditions, but that's now calledborder.modenow controls the interpolation type, e.g. if it's spline-based. This was done to start adding non-uniform fft interpolation, which is partially implemented here, but still waiting for ducc to support incremental nuffts.There is also a small change in the behavior of enmap.submap, which can cause 1-pixel shift in the size of the maps cut out with this operation due to differences in pixel rounding.
This update also contains the start of a new way to construct geometries that will make it easier to create patches with Fejer1 pixelization. This part isn't quite done yet though, but doesn't impact the existing geometry functions.