-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add devantech dS378 ethernet relay agent #694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! And sorry its taken so long to get to reviewing. This looks really good overall, just a couple of minor comments, mostly related to documentation. I also made a comment about robustness to network outages, but again that can be done later if needed.
Please make a merge commit to merge in the latest from main
while you're working on these.
Thanks for your detailed review! |
This isn't needed, since the params decorator prevents this ever being None.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for addressing all the comments, and for your detailed responses! A few more small suggestions.
It's great to see use of the TCPInterface
class too, glad that was straightforward. Just to confirm, the agent now can gracefully recover itself from a network interruption, say if you disconnected the network cable to the dS378?
I'm going to push a couple of small changes as well that I figured would just be quicker to do while I was re-reviewing. Please be sure to pull those before continuing with the suggested changes. Thanks again!
Thanks for the review and the comments! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing the suggestions, looks great!
Description
This pull request adds a new agent to operate devantech's dS378 ethernet relay.
Motivation and Context
Since dS378 is used in the electronics of the stimulator, the agent should be included in this repository.
How Has This Been Tested?
Test was done using the actual dS378 device.
Types of changes
Checklist: