Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACU: acuconfigs.yaml setting for forcing sequential moves #778

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

mhasself
Copy link
Member

@mhasself mhasself commented Oct 21, 2024

Description

This supports platforms where one generally doesn't want to move az and el axes simultaneously. When setting "axes_sequential" is enabled in acu-configs.yaml, it will perform all moves as multi-legged, separating az and el. This applies whether Sun Avoidance is on, or not. But special handling is applied, for case of Sun Avoidance.

Motivation and Context

Relates to simonsobs/scheduler#122, simonsobs/scheduler#100.

How Has This Been Tested?

Test case; tested on SATP1 today in sequential and simultaneous modes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

I'm going to rebase this before merging as a test of the recent code coverage reporting changes (the fact that you have a test addition here makes this a good test case.) I'll merge once that's done.

If enabled, this applies whether Sun Avoidance is on, or not.  But
special handling is applied, for case of Sun Avoidance.
@BrianJKoopman BrianJKoopman merged commit a38c3c6 into main Oct 31, 2024
6 checks passed
@BrianJKoopman BrianJKoopman deleted the mhasself/acu-seq-moves branch October 31, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants