wip: postgres integration #959
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iparask
requested review from
tskisner,
mhasself,
BrianJKoopman and
JBorrow
JBorrow
reviewed
Oct 23, 2024
| import gzip | ||
| import os | ||
|
|
||
| GET_TABLE_CREATE = """with table_info as ( |
There was a problem hiding this comment.
How was the schema being created before?
Wouldn't it be best to have this as part of a migration script, through alembic or similar, if we're not using an ORM?
There was a problem hiding this comment.
This is used to dump an existing DB to a file, similar to SQLite to file function. I do not know how the schema is created. @mhasself can you provide some more information here?
JBorrow
reviewed
Oct 23, 2024
| "`tag` varchar(256)", | ||
| "CONSTRAINT one_tag UNIQUE (`obs_id`, `tag`)", | ||
| "tags": [ | ||
| "obs_id varchar(256)", |
There was a problem hiding this comment.
It seems it is not. I think it should be and it will make search and joins even faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to continue the discussion about postgres as the metadata DB. I made some changes in ObsDB to connect to a postgres and run most of the ObsDB commands. I want to do some extra updates and then fix the unit test.
Having said that the size of the changes is not significant in terms of code that is changed. It is more to make sure the SQL code is correct.
Let me know what you think, because I will have to discuss it also with Research Computing at Princeton to have the ability to connect from the compute nodes.