Add DIDforsale SMS/MMS provider with API v4.0 support#89
Open
skybird-dev wants to merge 8 commits intosimontelephonics:release/16.0from
Open
Add DIDforsale SMS/MMS provider with API v4.0 support#89skybird-dev wants to merge 8 commits intosimontelephonics:release/16.0from
skybird-dev wants to merge 8 commits intosimontelephonics:release/16.0from
Conversation
…thods - Replace non-existent receiveMessage() call with connector->getMessage() - Add connector->emitSmsInboundUserEvt() to properly notify FreePBX system - Improve error handling and logging in callPublic() method - SMS messages will now be properly stored and routed to users/dialplan
…body - Move APIKEY and accesstoken to HTTP request headers - Keep SMS parameters (from, to, text, media_urls) in JSON body - Matches DIDforsale API v4.0 authentication requirements - Fixes 'Invalid format of header' error on outbound SMS
changed release URL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds full SMS and MMS support for DIDforsale via their API v4.0 to the FreePBX SMS Connector module.
Changes
providers/provider-Didforsale.php- Complete DIDforsale provider implementation (136 lines)module.xml- Version bumped to 16.0.19 with changelog entryREADME.md- Added DIDforsale documentation linkFeatures
✅ SMS Messaging - Full outbound SMS support via DIDforsale API v4.0
✅ MMS Support - Media URLs can be included in sendMedia() method
✅ Inbound Webhooks - Fully functional webhook handler for receiving inbound SMS
✅ Dual-Credential Authentication - Implements v4.0 requirement for both apikey and accesstoken
✅ Error Handling - Comprehensive logging and validation
Implementation Details
Testing
✅ Inbound SMS: Verified working - webhooks receive SMS and store in FreePBX database
✅ Database Integration: SMS visible in SMS Connector UI
✅ HTTPS/TLS: Connectivity confirmed from external hosts
⏳ Outbound SMS: Code complete - awaiting DIDforsale campaign registry configuration (external requirement)
Commits
Configuration
Users will need to:
Compatibility
Version Info