Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections.exists now uses any #730

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

PyWoody
Copy link

@PyWoody PyWoody commented Jan 31, 2025

The Collection.exists classmethod in llm.embedings currently builds the entire list of results then applies bool to convert the result set to a boolean.

With this PR, the Collection.exists classmethod takes advantage of any's early exiting to return True as soon as a result is found; otherwise, it will return False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant