Skip to content

fix: Hash-like Collection methods return Collections#91

Merged
silug merged 4 commits intosimp:mainfrom
silug:issue_37
Mar 19, 2026
Merged

fix: Hash-like Collection methods return Collections#91
silug merged 4 commits intosimp:mainfrom
silug:issue_37

Conversation

@silug
Copy link
Contributor

@silug silug commented Mar 19, 2026

Fixes #37

@silug silug marked this pull request as ready for review March 19, 2026 16:15
@silug silug requested review from Lt1201 and Copilot March 19, 2026 16:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Issue #37 by making ComplianceEngine::Collection’s Hash-like filtering methods return ComplianceEngine::Collection objects (instead of plain Hashes), and bumps the library/module version accordingly.

Changes:

  • Update ComplianceEngine::Collection so select/reject return Collections, and add/adjust related Hash-like iteration helpers.
  • Add RSpec coverage to assert Ces#select/#reject return ComplianceEngine::Ces instances and don’t mutate the original.
  • Bump version to 0.3.0 and document the change in the changelog.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
lib/compliance_engine/collection.rb Changes Hash-like methods (select/reject) to return Collections; adds values; adjusts enumerator behavior for each variants; adds transform_values.
spec/classes/compliance_engine/ces_spec.rb Adds specs asserting select/reject return the same Collection subtype and preserve the original collection.
lib/compliance_engine/version.rb Bumps gem/library version to 0.3.0.
metadata.json Bumps module version to 0.3.0.
CHANGELOG.md Adds 0.3.0 entry documenting Issue #37 change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

silug and others added 2 commits March 19, 2026 11:41
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@silug silug merged commit 5010109 into simp:main Mar 19, 2026
7 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Org Triage Mar 19, 2026
@silug silug deleted the issue_37 branch March 19, 2026 21:15
@silug silug removed this from Org Triage Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hash-like Collection methods should return Collections

4 participants