fix: Hash-like Collection methods return Collections#91
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #37 by making ComplianceEngine::Collection’s Hash-like filtering methods return ComplianceEngine::Collection objects (instead of plain Hashes), and bumps the library/module version accordingly.
Changes:
- Update
ComplianceEngine::Collectionsoselect/rejectreturn Collections, and add/adjust related Hash-like iteration helpers. - Add RSpec coverage to assert
Ces#select/#rejectreturnComplianceEngine::Cesinstances and don’t mutate the original. - Bump version to
0.3.0and document the change in the changelog.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
lib/compliance_engine/collection.rb |
Changes Hash-like methods (select/reject) to return Collections; adds values; adjusts enumerator behavior for each variants; adds transform_values. |
spec/classes/compliance_engine/ces_spec.rb |
Adds specs asserting select/reject return the same Collection subtype and preserve the original collection. |
lib/compliance_engine/version.rb |
Bumps gem/library version to 0.3.0. |
metadata.json |
Bumps module version to 0.3.0. |
CHANGELOG.md |
Adds 0.3.0 entry documenting Issue #37 change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Lt1201
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37