Skip to content

Fix test for small rho#81

Merged
jcapriot merged 1 commit intosimpeg:mainfrom
jcapriot:circle_fix
Oct 25, 2024
Merged

Fix test for small rho#81
jcapriot merged 1 commit intosimpeg:mainfrom
jcapriot:circle_fix

Conversation

@jcapriot
Copy link
Member

Checking for small k**2 was too aggressive, and would catch things when rho was big relative to a...

Instead check rho2 / (radius2 + z**2). I.e. check if the angle Rho-Z-Radius is small

Do a check for rho < sqrt(a**2 + z**2)
@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.93%. Comparing base (3b1f8d5) to head (4cb4a17).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   85.93%   85.93%           
=======================================
  Files          31       31           
  Lines        3149     3149           
=======================================
  Hits         2706     2706           
  Misses        443      443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapriot jcapriot merged commit 27a37a5 into simpeg:main Oct 25, 2024
@jcapriot jcapriot deleted the circle_fix branch October 25, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant