New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Copy/paste error in stm32g4 current sense #420

Open

dekutree64 opened this issue Jul 14, 2024 · 1 comment

Labels

Contributor

dekutree64 commented Jul 14, 2024

Spotted a probable copy/paste error while reading through https://github.com/simplefoc/Arduino-FOC/tree/master/src/current_sense/hardware_specific/stm32/stm32g4/stm32g4_utils.cpp
Line 208, shouldn't that be ADC_EXTERNALTRIG_T8_TRGO?

#ifdef TIM8 // if defined timer 8
else if(timer->getHandle()->Instance == TIM8)
return ADC_EXTERNALTRIG_T7_TRGO;
#endif

dekutree64 added the possible bug label

Collaborator

Candas1 commented Jul 14, 2024

Hi,

Yes that looks wrong.
I don't have this issue in the unified current sense I am working on, but it's not ready to be published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment