Generalise #173
Merged
Generalise #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addersuk
previously approved these changes
Jan 12, 2024
|
Found an edge case from looking at version-forget-me-not tests. |
addersuk
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason dobby worked with other languages is because of L59 in
lib/utils/bump.rb. Files likepackage.jsonandpyproject.tomlwere matching on the second part of the condition - the semver regex. It just so happened that in these files the first match is usually an app version number, but it's not guaranteed.This PR generalises and strengthens the regex matching. Now a match on just a version number will not work. Instead it matches on case insensitive "version" followed by a combo of spaces and a ":" or "=" separator, followed by a version number. This will hopefully make this more robust for python and js (and possibly other languages that version in a similar way).