preserve context when adding a new context provider #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is common need when creating a domain specific logger: we may want to provide domain specific ids (like user/session ids) inline with some generic ones (like Otel ids). Currently, we have to create a single lambda with all of the behaviour in it, which leads to lots of duplicated across apps.
|
/dobby version minor |
this is a very brittle test since it relies on the permanent loading of active_support
peaky76
approved these changes
Aug 2, 2024
chrisholmes
deleted the
preserve-context-when-supplying-new-context-providers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is common need when creating a domain specific logger: we may want to provide domain specific ids (like user/session ids) inline with some generic ones (like Otel ids). Currently, we have to create a single lambda with all of the behaviour in it, which leads to lots of duplicated across apps.