-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add F# #3259
base: main
Are you sure you want to change the base?
Add F# #3259
Conversation
Interestingly, this is already the third try to add this list:
I have read the comments on the previous attempts and fixed the issues that were discussed in there. Also, now this PR is open by an acting maintainer with all the necessary permissions in the list repository and willpower to make this inclusion to finally happen :) |
unicorn |
Sweet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Minor cosmetic consideration: I found that you might want to change:
- The terms ".NET" and ".Net" are used interchangeably. I mean not the links, but the descriptions of the links, like here:
Logary - Logary is a high performance, multi-target logging, metric, tracing and health-check library for mono and .Net.
- Space between "F# support(Windows only)" in the "IDE" section under "Development Tools"
Great work, have a nice day :) !
@Destray32 thanks for the review, I have fixed these issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Close
https://github.com/fsprojects/awesome-fsharp/
This is a list about F# programming language, already quite mature and with 1200 stars. We have other lists devoted to programming languages, so why don't add F# :)
✓ By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
My Reviews of Other PRs
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List
. It should not contain the wordAwesome
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Awesome X
and a logo withAwesome X
. You can put the header image in a#
(Markdown header) or<h1>
.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. The casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.