Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goodbye node.js Buffer #34

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Goodbye node.js Buffer #34

merged 6 commits into from
Jul 29, 2024

Conversation

bjornstar
Copy link
Contributor

A rough benchmark of the parallel test running 10000 times instead of 10 yielded a decent improvement:

  • new: 76.661ms
  • old: 90.661ms

I copied the bufferToHex function from browser into the node code to avoid using Buffer#toString('hex')

@sindresorhus
Copy link
Owner

I copied the bufferToHex function from browser into the node code to avoid using Buffer#toString('hex')

Maybe worth adding to https://github.com/sindresorhus/uint8array-extras ?

Or at least move it to an utilities.js file, so it's not duplicated.

@sindresorhus sindresorhus merged commit 1fbfeef into sindresorhus:main Jul 29, 2024
2 checks passed
@sindresorhus
Copy link
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants