feat: new FastAPI v3 API wrapping Analyticom KSI REST API by sindrig · Pull Request #131 · sindrig/vikes-match-clock

sindrig · 2026-02-16T15:58:28Z

Summary

Replace the fragile SOAP + HTML scraping Lambda functions with a clean FastAPI v3 API wrapping the Analyticom KSI REST API. Consolidates match data and weather into a single Lambda deployed behind API Gateway.

New FastAPI application in clock-api/v3/ with 6 endpoints (health, matches, lineups, events, match info, weather)
Terraform infrastructure for Lambda + API Gateway route at /v3/{proxy+}
TypeScript type generation from OpenAPI spec for future frontend migration
35 passing tests with TDD approach (unit, integration, handler tests)

What's New

API Endpoints

Method	Path	Description
`GET`	`/v3/health`	Health check
`GET`	`/v3/{team_id}/matches/{date}`	Matches for team on date
`GET`	`/v3/{team_id}/matches/{match_id}/lineups`	Match lineups
`GET`	`/v3/{team_id}/matches/{match_id}/events`	Match events (goals, cards, subs)
`GET`	`/v3/{team_id}/matches/{match_id}/info`	Detailed match info
`GET`	`/v3/weather?lat=&lon=`	Weather with vedur.is → OpenWeatherMap fallback

Key Design Decisions

One API key per team stored in SSM (/vikes-match-clock/ksi-api-key/{team_id})
Weather fallback chain: vedur.is (free, Iceland-specific) → OpenWeatherMap (global, paid)
Mangum adapter for Lambda deployment (no uvicorn in prod)
Pydantic v2 models with auto-generated OpenAPI spec

What's NOT Changed

No changes to existing Lambda functions (match-report, match-report-v2, weather)
No frontend changes (except generate-api-types script + generated types for future use)
Old APIs continue to work as-is — deprecation happens in a separate PR

Pre-merge Checklist

Set up SSM parameters for team API keys before first deploy
Consider adding sandbox-deploy label to test in staging first

Test Results

35 passed, 1 skipped

codecov · 2026-02-16T17:26:57Z

Codecov Report

❌ Patch coverage is 73.68421% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.38%. Comparing base (f70fe01) to head (3d1e7d3).

Files with missing lines	Patch %	Lines
clock/src/controller/asset/team/TodaysMatches.tsx	65.51%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   86.86%   86.38%   -0.49%     
==========================================
  Files          33       33              
  Lines        1599     1579      -20     
  Branches      467      458       -9     
==========================================
- Hits         1389     1364      -25     
- Misses        210      215       +5

Flag	Coverage Δ
unittests	`86.38% <73.68%> (-0.49%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
clock/src/controller/asset/team/Team.tsx	`100.00% <ø> (ø)`
.../src/controller/asset/team/TeamAssetController.tsx	`98.75% <100.00%> (-0.01%)`	⬇️
clock/src/controller/asset/team/TodaysMatches.tsx	`72.00% <65.51%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Implement matches endpoint that converts YYYY-MM-DD date to yyyyMMdd format, looks up team API key, and delegates to KsiClient. Router included in main app. TDD: tests written first, all 15 pass.

- Create tests/test_handler.py with 7 Mangum handler tests - Test Lambda event handling, response format, routing, and error cases - Validate OpenAPI spec completeness (6 endpoints present) - All 35 tests pass, no LSP errors - Evidence: task-8-handler-tests.txt, task-8-openapi-validation.txt, task-8-openapi-spec.json

Create clock-api/v3/AGENTS.md with full API documentation including endpoints, architecture, development setup, and testing patterns. Update root AGENTS.md to reference v3 and mark legacy APIs. Update infra/AGENTS.md with clock-api-v3 Lambda entry. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

Remove the .sisyphus internal tracking folder from the repository while keeping it locally. Update .gitignore to prevent it from being tracked in the future. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

Remove nested .sisyphus from clock-api/v3/ and update .gitignore to recursively ignore any .sisyphus directories found in the project. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

…is fallback

- Migrate weather.ts to use v3 fetchWeather endpoint - Migrate getAvailableMatches action to use v3 adapter with team_id - Add teamId field to screen config in ListenersState - Update reducer to handle new data shape - Migrate MatchesOnPitch component (all 3 methods) to v3 API - Remove search-for-player feature from Team.tsx All API calls now use v3 endpoints with team_id parameter. Fallback to team_id 2492 (Víkingur in Analyticom API).

- Fix TypeScript types in v3-api.ts (use ListenersState['screens']) - Update lambda-example.ts to match new AvailableMatches shape - Add numeric id fields to all debug players - Replace 'as any' with proper type assertion All ESLint errors resolved, build and lint pass cleanly.

…olution - KsiClient now accepts api_key in constructor - All methods use self.api_key (no per-method parameter) - get_ksi_client dependency resolves key automatically - Router endpoints no longer manually call get_ksi_api_key - Tests updated to match new dependency pattern Eliminates repetitive api_key = get_ksi_api_key(team_id) in every endpoint. All 33 tests pass.

…tier

github-actions · 2026-02-19T23:44:28Z

Deployed to staging: https://staging.irdn.is

github-actions · 2026-02-20T21:35:51Z

Deployed to staging: https://staging.irdn.is

github-actions · 2026-02-20T23:14:55Z

Deployed to staging: https://staging.irdn.is

github-actions · 2026-02-21T20:58:09Z

Deployed to staging: https://staging.irdn.is

github-actions · 2026-02-21T21:06:39Z

Deployed to staging: https://staging.irdn.is

sindrig added the sandbox-deploy label Feb 19, 2026

sindrig force-pushed the new-api branch from 5fa48f7 to 83063d5 Compare February 19, 2026 23:09

sindrig and others added 21 commits February 19, 2026 23:13

feat(api): scaffold FastAPI v3 project with Mangum adapter

6ee7249

feat(api): add Pydantic models and KSI API client with tests

3c8a34f

feat(api): add GET /{team_id}/matches/{date} endpoint with tests

9b6800f

Implement matches endpoint that converts YYYY-MM-DD date to yyyyMMdd format, looks up team API key, and delegates to KsiClient. Router included in main app. TDD: tests written first, all 15 pass.

infra: add Lambda and API Gateway route for FastAPI v3

d2f30ed

feat(api): add OpenAPI to TypeScript type generation script

6e7783f

style(api): apply Black formatting (79 char line length)

2dd957c

style(api): remove all comments and docstrings

391182d

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

refactor(api): replace Mangum with Lambda Web Adapter + uvicorn

bf2db5e

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

docs: update AGENTS.md for LWA migration and no-comments rule

3061c9f

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

style(api): use return await directly in match router endpoints

0f3ad36

refactor(api): make OpenWeatherMap primary weather source with vedur.…

f73875c

…is fallback

throw

bfe1737

feat(clock): add v3 API adapter module with data transformation

42f7d08

fix(clock): remove unused Player import from MatchesOnPitch

b5d791d

sindrig force-pushed the new-api branch from 83063d5 to b5d791d Compare February 19, 2026 23:24

sindrig added 2 commits February 19, 2026 23:27

style(clock): format MatchesOnPitch and TeamAssetController with Pret…

d98ceb7

…tier

test(clock): update specs for v3 API migration

cea83ec

todays matches

e7ae752

fix api url

0d2399f

/v3 prefix fix

22ae72c

logging

3d1e7d3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: new FastAPI v3 API wrapping Analyticom KSI REST API#131

feat: new FastAPI v3 API wrapping Analyticom KSI REST API#131
sindrig wants to merge 27 commits intomasterfrom
new-api

sindrig commented Feb 16, 2026

Uh oh!

codecov bot commented Feb 16, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Conversation

sindrig commented Feb 16, 2026

Summary

What's New

API Endpoints

Key Design Decisions

What's NOT Changed

Pre-merge Checklist

Test Results

Uh oh!

codecov bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

github-actions bot commented Feb 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov bot commented Feb 16, 2026 •

edited

Loading