Skip to content

Comments

Change event revenue attributes to type: numeric#25

Open
mhimi1 wants to merge 1 commit intosinger-io:masterfrom
mhimi1:fix/bigquery-event-revenue-type
Open

Change event revenue attributes to type: numeric#25
mhimi1 wants to merge 1 commit intosinger-io:masterfrom
mhimi1:fix/bigquery-event-revenue-type

Conversation

@mhimi1
Copy link

@mhimi1 mhimi1 commented May 5, 2020

event_revenue and event_revenue_usd are of type string. This causes issues in BigQuery when doing sums. Changed to numeric

Description of change

event_revenue and event_revenue_usd are of type string. This causes issues in BigQuery when doing sums. Changed to numeric

Manual QA steps

Risks

  • Unsure whether this would break non BigQuery integrations?

Rollback steps

  • revert this branch

…causes issues in BigQuery when doing sums. Changed to numeric
@gaberogan
Copy link

With this I get:

singer.transform.SchemaMismatch: Errors during transform
	event_revenue: 2.99 does not match {'type': ['numeric', 'null']}

It seems that 2.99 is somehow a string and Singer doesn't like transforming it to a number. I'm not very familiar with how this process should work but it seems this PR needs to handle this better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants