Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This pull request improves the handling of datetime objects in
tap_appsflyer/__init__.pyto ensure all datetime values are timezone-aware (specifically in UTC). This helps prevent subtle bugs when comparing or manipulating datetimes, especially when mixing naive and timezone-aware objects.TypeError: can't compare offset-naive and offset-aware datetimesTimezone handling improvements:
ensure_timezone_aware(dt)helper function that ensures any datetime object is timezone-aware in UTC, assuming naive objects are in UTC and leaving aware objects unchanged.get_stopfunction to useensure_timezone_awarefor bothstart_datetimeandstop_time, ensuring safe and consistent datetime comparisons.datetime.datetime.now()insync_organic_installsto explicitly use UTC (datetime.datetime.now(pytz.utc)), aligning with the new timezone-aware handling.Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code