TDL-18879: Clear offset when max_skip error is encountered and return 0 if skip is greater than 250k in the current state.
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbshah1212
reviewed
May 3, 2022
tap_closeio/streams.py
Outdated
| if not date_window: | ||
| LOGGER.warning("Invalid value of date window is passed: \'{}\', using default window size of 15 days.".format(ctx.config.get("date_window"))) | ||
| date_window = 15 | ||
| LOGGER.warning("Invalid value of date window is passed: \'{}\', using default window size of 5 days.".format(ctx.config.get("date_window"))) |
There was a problem hiding this comment.
Suggested change
| LOGGER.warning("Invalid value of date window is passed: \'{}\', using default window size of 5 days.".format(ctx.config.get("date_window"))) | |
| LOGGER.warning("Invalid value of date window is passed: \'{}\', using default window size of {} days.".format(ctx.config.get("date_window")),DATE_WINDOW_SIZE) |
dbshah1212
reviewed
May 3, 2022
tap_closeio/streams.py
Outdated
| except ValueError: | ||
| LOGGER.warning("Invalid value of date window is passed: \'{}\', using default window size of 15 days.".format(ctx.config.get("date_window"))) | ||
| LOGGER.warning("Invalid value of date window is passed: \'{}\', using default window size of 5 days.".format(ctx.config.get("date_window"))) |
There was a problem hiding this comment.
Suggested change
| LOGGER.warning("Invalid value of date window is passed: \'{}\', using default window size of 5 days.".format(ctx.config.get("date_window"))) | |
| LOGGER.warning("Invalid value of date window is passed: \'{}\', using default window size of {} days.".format(ctx.config.get("date_window")), DATE_WINDOW_SIZE) |
tap_closeio/streams.py
Outdated
| date_window = int(ctx.config.get("date_window", 15)) | ||
| # if date_window is 0, '0' or None, then set default window size of 15 days | ||
| date_window = int(ctx.config.get("date_window", DATE_WINDOW_SIZE)) | ||
| # if date_window is 0, '0' or None, then set default window size of 5 days |
There was a problem hiding this comment.
Suggested change
| # if date_window is 0, '0' or None, then set default window size of 5 days | |
| # if date_window is 0, '0' or None, then set the default window size to DATE_WINDOW_SIZE(5 days) |
dbshah1212
approved these changes
May 3, 2022
savan-chovatiya
approved these changes
May 3, 2022
luandy64
requested changes
May 3, 2022
hpatel41
changed the title
max_skip error is encountered and return 0 if skip is greater than 250k in the current state.
tap_closeio/context.py
Outdated
| @@ -46,7 +46,10 @@ def set_bookmark(self, path, val): | |||
|
|
|||
| def get_offset(self, path): | |||
| off = bks_.get_offset(self.state, path[0]) | |||
| return (off or {}).get(path[1]) | |||
| value = (off or {}).get(path[1]) | |||
| if path[0] == "activities" and value > 250000: | |||
There was a problem hiding this comment.
Add a comment here regarding a specific scenario like when the state reached this condition for the customer with the previous version and this will reduce skip to 0 for date_windowing and all.
tap_closeio/streams.py
Outdated
| ctx.write_state() | ||
| if 'max_skip = ' in str(e): | ||
| if tap_stream_id == IDS.ACTIVITIES: | ||
| LOGGER.warning("The skip cannot be greater than 250000, please reduce the date window size and try again.") |
There was a problem hiding this comment.
Suggested change
| LOGGER.warning("The skip cannot be greater than 250000, please reduce the date window size and try again.") | |
| LOGGER.warning("Hit max_skip error so clearing skip offset, please reduce the date window size and try again.") |
dbshah1212
reviewed
May 5, 2022
tap_closeio/streams.py
Outdated
| # clear offset | ||
| ctx.clear_offsets(tap_stream_id) | ||
| ctx.write_state() | ||
| raise |
There was a problem hiding this comment.
Need to add the message to reduce the date window.
There was a problem hiding this comment.
Updated error message
dbshah1212
reviewed
May 5, 2022
| ctx.write_state() | ||
| if 'max_skip = ' in str(e): | ||
| if tap_stream_id == IDS.ACTIVITIES: | ||
| LOGGER.warning("Hit max_skip error so clearing skip offset, please reduce the date window size and try again.") |
There was a problem hiding this comment.
It should be an error and must be raised with this message.
dbshah1212
approved these changes
May 5, 2022
savan-chovatiya
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-18879: Clear offset when max_skip error is encountered and return 0 if skip is greater than 250k in the current state.
max_skiperror.Manual QA steps
Risks
Rollback steps