Add parent-tap-stream-id key in metadata #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying parent stream relationships in metadata by introducing a "parent-tap-stream-id" metadata key. This allows streams to declare their parent stream for hierarchical data relationships.
- Adds logic to check for a
parentattribute on streams and write it to metadata - Updates the
ListUsersstream to specify "lists" as its parent stream
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
RushiT0122
requested changes
Oct 15, 2025
RushiT0122
left a comment
RushiT0122
left a comment
There was a problem hiding this comment.
Please update discovery integration test.
RushiT0122
approved these changes
Oct 17, 2025
RushiT0122
left a comment
RushiT0122
left a comment
There was a problem hiding this comment.
Approving but update the tap version to minor version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
SAC-28849
Manual QA steps
Run Discovery
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code