Tdl 24072 fix typecasting bug max api limit

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 2.5.1
+  * Fixed Validation Error for `max_daily_calls` [#84](https://github.com/singer-io/tap-marketo/pull/84)
+
 ## 2.5.0
   * Add campaignId field to activities streams [#82](https://github.com/singer-io/tap-marketo/pull/82)
 

setup.py

@@ -3,7 +3,7 @@
 from setuptools import setup
 
 setup(name='tap-marketo',
-      version='2.5.0',
+      version='2.5.1',
       description='Singer.io tap for extracting data from the Marketo API',
       author='Stitch',
       url='http://singer.io',

tap_marketo/client.py

@@ -26,7 +26,7 @@
 # Marketo limits REST requests to 50000 per day with a rate limit of 100
 # calls per 20 seconds.
 # http://developers.marketo.com/rest-api/
-MAX_DAILY_CALLS = int(50000 * 0.8)
+MAX_DAILY_CALLS = 50000 * 0.8
 RATE_LIMIT_CALLS = 100
 RATE_LIMIT_SECONDS = 20
 
@@ -80,7 +80,7 @@ def raise_for_rate_limit(data):
 class Client:
     # pylint: disable=unused-argument
     def __init__(self, endpoint, client_id, client_secret,
-                 max_daily_calls=MAX_DAILY_CALLS,
+                 max_daily_calls=None,
                  user_agent=DEFAULT_USER_AGENT,
                  job_timeout=JOB_TIMEOUT,
                  poll_interval=POLL_INTERVAL,
@@ -89,7 +89,13 @@ def __init__(self, endpoint, client_id, client_secret,
         self.domain = extract_domain(endpoint)
         self.client_id = client_id
         self.client_secret = client_secret
-        self.max_daily_calls = int(max_daily_calls)
+        try:
+            self.max_daily_calls = int(max_daily_calls or MAX_DAILY_CALLS)
+        except (ValueError, TypeError):
+            # Raises TypeError for None / Null Value
+            # Raises ValueError for "" / bool value
+            self.max_daily_calls = int(MAX_DAILY_CALLS)
+
         self.user_agent = user_agent
         self.job_timeout = job_timeout
         self.poll_interval = poll_interval

tests/test_client_max_api_limit.py

@@ -0,0 +1,57 @@
+import unittest
+from datetime import datetime,timedelta
+from tap_marketo.client import Client, MAX_DAILY_CALLS
+
+class TestDateWindowConfig(unittest.TestCase):
+
+    def test_datewindow_disabled_no_val(self):
+        """
+            Verify that daily_calls_limit is default if no value is passed
+        """
+        # Initialize Client object
+        client = Client(**{'endpoint': "123-ABC-789",'client_id':'ABC-123','client_secret':'123-QRT'})
+
+        self.assertEqual(client.max_daily_calls, MAX_DAILY_CALLS)
+
+    def test_datewindow_disabled_empty_str(self):
+        """
+            Verify that daily_calls_limit is default if empty string value is passed
+            Verify no Exception is raised for typecasting error between str to num
+        """
+        # Initialize Client object
+        client = Client(**{'endpoint': "123-ABC-789",'client_id':'ABC-123','client_secret':'123-QRT',"max_daily_calls":""})
+
+        self.assertEqual(client.max_daily_calls, MAX_DAILY_CALLS)
+
+    def test_datewindow_disabled_bool_val(self):
+        """
+            Verify that daily_calls_limit is default if bool value is passed
+        """
+        # Initialize Client object
+        client = Client(**{'endpoint': "123-ABC-789",'client_id':'ABC-123','client_secret':'123-QRT','max_daily_calls':False})
+        self.assertEqual(client.max_daily_calls ,MAX_DAILY_CALLS)
+
+    def test_datewindow_disabled_num_val(self):
+        """
+            Verify that api_limit is 0 if 0 value is passed
+        """
+        # Initialize Client object
+        client = Client(**{'endpoint': "123-ABC-789",'client_id':'ABC-123','client_secret':'123-QRT',"max_daily_calls":0})
+        self.assertEqual(client.max_daily_calls, MAX_DAILY_CALLS)
+
+    def test_datewindow_disabled_none_val(self):
+        """
+            Verify that api_limit is default if None value is passed
+        """
+        # Initialize Client object
+        client = Client(**{'endpoint': "123-ABC-789",'client_id':'ABC-123','client_secret':'123-QRT',"max_daily_calls":None})
+        self.assertEqual(client.max_daily_calls, MAX_DAILY_CALLS)
+
+    def test_datewindow_enabled_num_val(self):
+        """
+            Verify that api_limit is set appropriately if num value is passed
+        """
+        # Initialize Client object
+        client = Client(**{'endpoint': "123-ABC-789",'client_id':'ABC-123','client_secret':'123-QRT',"max_daily_calls":3})
+
+        self.assertEqual(client.max_daily_calls, 3)