add go linter to linux workflow #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singholt
force-pushed
the
go-linter
branch
12 times, most recently
from
93c1c17 to
d9c012d
Compare
singholt
pushed a commit
that referenced
this pull request
Aug 15, 2022
…ainers. (#3) * First cut of the changes. * Intermediate check-in before refactoring to hashing the paths. * Refactored the code to use a concatenated hashed value for the CredSpec filename. * Cleaning the cruft. * Simplified the code a bit and incorporated the first round of PR review comments. * Arranged the imports as per the language spec. * Fixed a broken test. * Fixed a few more broken tests. * Refactored the code to only use the credspecContainer Map. * Fixed more references and tests. * Fixed more tests. * Fixed more tests. * Fixed more tests. * Fixed more tests. * Improved the documentation for the member variable. * Incorporated some review comments. * Removed the unnecessary method and cleaned up the code a bit. * Some more clean-up of the code. * Tidying the imports.
singholt
pushed a commit
that referenced
this pull request
Jan 2, 2025
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
testing go-linter
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.