Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create import map if not present in azure storage #109

Merged
merged 1 commit into from
May 7, 2021
Merged

Create import map if not present in azure storage #109

merged 1 commit into from
May 7, 2021

Conversation

tungurlakachakcak
Copy link
Contributor

Resolves #98 for one more I/O method

Tests:

  1. Started with no file in Azure blob storage

  2. Started the server

  3. The file was auto-created

  4. Had a import-map file in azure blob storage

  5. Started the server

  6. The file was not reset

joeldenning
joeldenning approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@joeldenning joeldenning merged commit f662d3d into single-spa:main May 7, 2021
@joeldenning joeldenning mentioned this pull request May 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeldenning joeldenning joeldenning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create empty file when not found
2 participants
@tungurlakachakcak @joeldenning