Skip to content

Conversation

@sinshu
Copy link
Owner

@sinshu sinshu commented Nov 25, 2025

Summary

  • update the CI workflow to restore and test using the new NumFlat.slnx solution file

Testing

  • not run

Codex Task

@sinshu sinshu merged commit 5a74bfa into main Nov 25, 2025
1 check passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 14 to +18
- uses: actions/setup-dotnet@v4
with:
dotnet-version: 8.0.x
- run: dotnet restore
- run: dotnet test NumFlat.sln --configuration Release
- run: dotnet restore NumFlat.slnx
- run: dotnet test NumFlat.slnx --configuration Release

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge .NET 8 workflow cannot run .slnx solution

The workflow installs the .NET 8.0.x SDK and then calls dotnet restore NumFlat.slnx and dotnet test NumFlat.slnx. The new .slnx solution format is only supported by newer SDK/MSBuild versions; the 8.x CLI accepts .sln/.slnf only, so on the GitHub runner these steps will fail before tests execute and CI remains red. Updating the SDK to a version that understands .slnx or using a compatible solution file is needed for the job to succeed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants