-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Reminders for Live Sessions from Subject Calendars #32
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: lmaotrigine <57328245+lmaotrigine@users.noreply.github.com>
i need sleep
Co-authored-by: lmaotrigine <57328245+lmaotrigine@users.noreply.github.com>
Co-authored-by: lmaotrigine <57328245+lmaotrigine@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this check and where does it come from?
This check only allows admins to use (checks for role id). This is pre-existing in the bot, used in |
I don't think you've imported the check? pyright is failing. |
you're right, idk why it wasn't included in the commit since I remember importing. git kinda sus. fixing |
divorce shitty pagination library
This fails literally every check now after you merged this into my branch and then back again. It happens sometimes when you rely on auto-resolution. Can you run pre-commit again? For future reference, rebases are ok in offshoot branches since when this gets merged into main, it's going to get squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeet all references to menus, they're not used anywhere anymore. i already have a PageSource configured at the bottom of the file.
the timing xd |
better dockerignore
is it ready now @lmaotrigine, or we missing something (apart from the pre-merge checklist I sent in the initial message) ? |
LGTM. You can probably add instructions for deployment with docker to the readme if you like. |
should I close this PR? |
Thanks for your PR! I apologize for the delayed response. After multiple meetings with the team[Admin, moderators of the server], we've decided not to include this feature in the server for now. We appreciate your effort and creativity. We may need similar functionality when we work on the website project. Please don't hesitate to discuss this feature on our Discord channel. Thanks for being awesome! |
I'll leave this open then if you guys change your mind later down the line |
This sends a reminder in the respective subject's channel
5 minutes
(can be changed) before and when a live session is going to start on the respective subject calendars. Members can opt-in to the pings via selecting the role to receive these alerts.Miscellaneous Changes
[+]
AddedDockerfile
to run bot in a container for testingChecklist before deploying to prod
prod
Future Improvements
Screenshots from testing server
Reminder Notification
Event Notification
Credits
Big thanks to @lmaotrigine for helping me with async-ifying everything