Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Reminders for Live Sessions from Subject Calendars #32

Open
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

kry0sc0pic
Copy link
Contributor

@kry0sc0pic kry0sc0pic commented Jul 23, 2023

This sends a reminder in the respective subject's channel 5 minutes (can be changed) before and when a live session is going to start on the respective subject calendars. Members can opt-in to the pings via selecting the role to receive these alerts.

Miscellaneous Changes
[+] Added Dockerfile to run bot in a container for testing

Checklist before deploying to prod

  • Create a new ping role on server and update it in config
  • Update Environment to prod
  • Add more calendars as necessary

Future Improvements

  • Move calendars to a database so they can be updated without restarting bot since they will be needed to be updated as terms change

Screenshots from testing server

  • Reminder Notification
image
  • Event Notification
image

Credits
Big thanks to @lmaotrigine for helping me with async-ifying everything

kry0sc0pic and others added 6 commits July 25, 2023 20:31
Co-authored-by: lmaotrigine <57328245+lmaotrigine@users.noreply.github.com>
i need sleep
Co-authored-by: lmaotrigine <57328245+lmaotrigine@users.noreply.github.com>
Co-authored-by: lmaotrigine <57328245+lmaotrigine@users.noreply.github.com>
Copy link
Contributor

@lmaotrigine lmaotrigine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this check and where does it come from?

@kry0sc0pic
Copy link
Contributor Author

kry0sc0pic commented Jul 26, 2023

what is this check and where does it come from?

This check only allows admins to use (checks for role id).

This is pre-existing in the bot, used in cogs/verification.py. Using that to keep it consistent with rest of the gated commands

@lmaotrigine
Copy link
Contributor

I don't think you've imported the check? pyright is failing.

@kry0sc0pic
Copy link
Contributor Author

you're right, idk why it wasn't included in the commit since I remember importing. git kinda sus. fixing

@lmaotrigine
Copy link
Contributor

This fails literally every check now after you merged this into my branch and then back again. It happens sometimes when you rely on auto-resolution. Can you run pre-commit again?

For future reference, rebases are ok in offshoot branches since when this gets merged into main, it's going to get squashed.

Copy link
Contributor

@lmaotrigine lmaotrigine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeet all references to menus, they're not used anywhere anymore. i already have a PageSource configured at the bottom of the file.

cogs/live_ping.py Outdated Show resolved Hide resolved
cogs/live_ping.py Outdated Show resolved Hide resolved
@kry0sc0pic
Copy link
Contributor Author

the timing xd

@kry0sc0pic
Copy link
Contributor Author

kry0sc0pic commented Aug 1, 2023

is it ready now @lmaotrigine, or we missing something (apart from the pre-merge checklist I sent in the initial message) ?

@lmaotrigine
Copy link
Contributor

LGTM. You can probably add instructions for deployment with docker to the readme if you like.

@kry0sc0pic
Copy link
Contributor Author

kry0sc0pic commented Oct 11, 2023

should I close this PR?

@sinsniwal
Copy link
Owner

should I close this PR?

Thanks for your PR! I apologize for the delayed response. After multiple meetings with the team[Admin, moderators of the server], we've decided not to include this feature in the server for now. We appreciate your effort and creativity. We may need similar functionality when we work on the website project. Please don't hesitate to discuss this feature on our Discord channel. Thanks for being awesome!

@kry0sc0pic
Copy link
Contributor Author

I'll leave this open then if you guys change your mind later down the line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants