Merge pull request #335 from fmkra/fix/css-bundle-size

Reduce CSS bundle
sio2project · Mar 13, 2024 · 5414a6c · 5414a6c
2 parents 16230de + d81aea6
commit 5414a6c
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 7 deletions.
diff --git a/oioioi/contests/static/common/contests.scss b/oioioi/contests/static/common/contests.scss
@@ -1,5 +1,4 @@
 @import "scss/utility";
-@import "scss/style";
 
 $list-grid-column-min-width: 70px !default;
 $list-grid-column-count: 5 !default;
@@ -30,7 +29,11 @@ $list-subheader-bgcolor: #eee !default;
 
 .form-list-unstyled {
   ul {
-    @extend .list-unstyled;
+    // Should be @extend .list-unstyled
+    // but it requires whole scss/style
+    // which increases bundle size dramatically
+    padding-left: 0;
+    list-style: none;
   }
 }
 

diff --git a/oioioi/programs/static/common/programs.scss b/oioioi/programs/static/common/programs.scss
@@ -1,4 +1,9 @@
-@import "scss/style";
+@import "bootstrap/stylesheets/_functions";
+@import "bootstrap/stylesheets/_variables";
+@import "bootstrap/stylesheets/mixins/_breakpoints";
+@import "bootstrap/stylesheets/mixins/_border-radius";
+@import "bootstrap/stylesheets/mixins/_hover";
+@import "bootstrap/stylesheets/_card";
 
 .test-actions {
   visibility: hidden;
@@ -70,7 +75,10 @@
 
   .linenodiv, .syntax-highlight {
     @extend .card;
-    @extend .bg-light;
+    // Should be @extend .bg-light
+    // but it requires whole bootstrap to be included
+    // which increases bundle size dramatically
+    background-color: #f8f9fa !important;
     padding: ($spacer * 0.5);
   }
 }
@@ -82,7 +90,10 @@
 
   &.line-numbers, &.code {
     @extend .card;
-    @extend .bg-light;
+    // Should be @extend .bg-light
+    // but it requires whole bootstrap to be included
+    // which increases bundle size dramatically
+    background-color: #f8f9fa !important;
     padding: ($spacer * 0.5);
   }
 }
diff --git a/oioioi/programs/static/common/submission-diff.scss b/oioioi/programs/static/common/submission-diff.scss
@@ -1,5 +1,3 @@
-@import "scss/style";
-
 $left-diff-text: #b94a48 !default;
 $left-diff-background: #f2dede !default;
 $right-diff-text: #468847 !default;