Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #206 solve: Autocomplete search fields #217

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Aszanat
Copy link
Contributor

@Aszanat Aszanat commented May 25, 2023

I reorganized admin.py and forms.py in contests because I found a form in admin.py
Also, I added autocomplete search field in a place found in the issue, works as intended.

Zuzanna Kaczorek and others added 7 commits March 6, 2023 15:27
commit b7f1d0adeba8b4e4b9371edd94511be532021e38
Author: Zuzanna Kaczorek <zk429289@students.mimuw.edu.pl>
Date:   Mon Mar 6 15:26:24 2023 +0100

    Fixing what I just messed up with git add and branches

commit f12cd3e1d5b59676b6ad9a51e45976c495fd7c5c
Author: Zuzanna Kaczorek <zk429289@students.mimuw.edu.pl>
Date:   Mon Mar 6 15:06:47 2023 +0100

    Fixtures for teachers modified to include join_date

commit 91b043a
Author: Zuzanna Kaczorek <zk429289@students.mimuw.edu.pl>
Date:   Mon Jan 30 17:16:55 2023 +0100

    (Partial solve for sio2project#94) Added timestamps (join date) for teachers.

commit 5498524
Author: Zuzanna Kaczorek <zk429289@students.mimuw.edu.pl>
Date:   Mon Jan 16 21:26:47 2023 +0100

    Added search fields to admin's view on teachers, added more fields to show on teachers list
…ield for adding permissions for teachers to a contest
@Aszanat Aszanat requested a review from twalen as a code owner May 25, 2023 16:44
@otargowski
Copy link
Contributor

I would also add autocompletion to the form for adding new participants to a contest.
Additionally, I don't think we should filter out non-teachers, as they are often non-existent (like on sio2.mimuw, basing on the lack of "Request teacher account" in the user menu) and even if enabled, probably not all contest rights (especially observer ones) would be given to teachers only.

PS.
I think you accidentally deleted .gitignore.

.gitignore Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this file from PR

@@ -695,3 +695,7 @@ def reattach_problem_confirm_view(request, problem_instance_id, contest_id):
'contests/reattach_problem_confirm.html',
{'problem_instance': problem_instance, 'destination_contest': contest},
)

def get_teacher_names(request):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this view needs to be protected (i.e. only for admins)

Copy link
Contributor

@twalen twalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove .gitignore
fix permission issues

Zuzanna Kaczorek added 2 commits June 5, 2023 14:29
…a name (teacher_search) that it should know as far as I understand.
@Aszanat Aszanat marked this pull request as draft June 15, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants