Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display % of points granted by the checker when partially scoring #301

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SZonkil
Copy link
Contributor

@SZonkil SZonkil commented Dec 6, 2023

Addition of translation is required

Closes #288

@SZonkil SZonkil requested a review from twalen as a code owner December 6, 2023 15:29
Copy link
Contributor

@DietPawel DietPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for delivering a PR. Did You tested the translations?

I tried testing it and it seems that when You change user's language the comment is not reflected.

I believe that, this string "Granted...." is saved during judging of the problem and there is no access to user's language preferences there.

I might have clicked something wrong though.

twalen
twalen previously approved these changes Dec 20, 2023
oioioi/programs/handlers.py Outdated Show resolved Hide resolved
oioioi/programs/models.py Outdated Show resolved Hide resolved
oioioi/programs/templates/programs/report-comments.html Outdated Show resolved Hide resolved
@DietPawel DietPawel changed the title Display % of points outpu by checker Display % of points granted by the checker when partially scoring. Dec 20, 2023
@DietPawel DietPawel changed the title Display % of points granted by the checker when partially scoring. Display % of points granted by the checker when partially scoring Dec 20, 2023
@DietPawel
Copy link
Contributor

CC: @Kostero @craniac-swistak

twalen
twalen previously approved these changes Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

% of points output by chk to be displayed by SIO
5 participants