-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show aggregated tags in settings #444
Merged
segir187
merged 37 commits into
sio2project:master
from
segir187:AggregatedTagsInSettings
Jan 20, 2025
Merged
Show aggregated tags in settings #444
segir187
merged 37 commits into
sio2project:master
from
segir187:AggregatedTagsInSettings
Jan 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mTagProposal is created. This is most likely a temporary implementation.
…happen when adding or deleting AlgorithmTagProposals.
…al, correct increase function to only increase amount of AggregatedTag if a new AlgorithmTagProposal is created, not when modified.
…ifficultyTag classes and test_tag_proposals.py file, testing AlgorithmTagProposal and DifficultyTagProposal classes.
…eck AggregatedAlgorithmTagProposal.
…ew in TestTagProposals class. Fix mistaken 'assertEquals' to 'assertEqual'.
…st_users fixture.
… tag proposals for given aggregated model.
…from aggregated tag models.
All but last 4 commits are in #431. |
twalen
reviewed
Jan 20, 2025
twalen
reviewed
Jan 20, 2025
oioioi/problems/templatetags/tag.py
Outdated
def aggregated_tag_label(aggregated_tag): | ||
prefix = get_tag_prefix(aggregated_tag) | ||
return format_html( | ||
u'<a title="{tooltip}" class="badge tag-label tag-label-{cls}" href="{href}" ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u is not needed
twalen
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #436.
Merge only after merging PR #431.