Fix flaky test TestProblemsetFilters::test_filters. Closes #440 #450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
This test used to check for the presence of a problem by asserting that the response HTML contained the problem name.
However, the response also included an HTML form with a generated CSRF token, sometimes this token would contain the problem name (test problems have short names like
aaa
so it wasn't that rare).This caused the test to randomly fail.
Solution
Now the test expliclitly searches for a HTML tag with the necessary problem name.