Run latest tsc in CI

react-scripts prevents us from depending on tsc 5.x, but we need to use tsc 5.x for type checking so that "moduleResolution": "bundler" is supported; use npx to run the latest tsc in CI.
sipb · Dec 2, 2024 · dd1a8f4 · dd1a8f4
1 parent 9f9ba5f
commit dd1a8f4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -21,7 +21,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
-    - name: Use Node.js ${{ env.node-version }}
+    - name: Install node
       uses: actions/setup-node@v4
       with:
         node-version: ${{ env.node-version }}
@@ -35,7 +35,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
-    - name: Use Node.js ${{ env.node-version }}
+    - name: Install node
       uses: actions/setup-node@v4
       with:
         node-version: ${{ env.node-version }}
@@ -45,6 +45,6 @@ jobs:
     - name: Run ESLint
       run: npm run ci-eslint
     - name: Run tsc
-      run: npm run ci-tsc
+      run: npx tsc@latest
     - name: Run build
       run: npm run build
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -34,8 +34,7 @@
     "eject": "react-scripts eject",
     "format": "prettier --write **/*.{ts,tsx}",
     "ci-prettier": "prettier --check **/*.{ts,tsx}",
-    "ci-eslint": "eslint **/*.{ts,tsx}",
-    "ci-tsc": "tsc"
+    "ci-eslint": "eslint **/*.{ts,tsx}"
   },
   "eslintConfig": {
     "extends": [