Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating high contrast and high contrast (dark) color palettes #92

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

sarahjohn1
Copy link
Contributor

This pull request would close #87

Updated the color palettes for both high contrast and high contrast (dark). From the re

  1. Original High Contrast Dark
Screenshot 2024-12-04 at 3 39 45 PM
  1. Classic Dark (for reference, was not edited)
Screenshot 2024-12-04 at 3 46 47 PM
  1. Updated High Contrast Dark
Screenshot 2024-12-04 at 3 40 31 PM
  1. Original High Contrast
Screenshot 2024-12-04 at 3 41 02 PM
  1. Updated High Contrast
Screenshot 2024-12-04 at 3 41 31 PM

Copy link
Member

@cjquines cjquines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

i wonder if we can have a build step that ensures high contrast colors are wcag aaa?

Copy link
Member

@psvenk psvenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR; these colors have much better foreground/background contrast than what we have currently. I just have a few questions:

  • Could we make the purple (#BA68C8) a little lighter so that it passes WCAG AAA?
  • The blues (#4FC3F7 and #64B5F6) are very similar to each other, as are the red and the pink (#FF6B6B and #FF80A4) to a lesser extent. Would it be possible to make them more distinct while keeping them distinct from the other colors and compliant with WCAG AAA?

@sarahjohn1
Copy link
Contributor Author

Yes of course, here are updated values and wcag contrast checkers, sorry I didn't think of this earlier! Values are updated and here are screenshots to accompany.
Screenshot 2024-12-08 at 1 07 55 AM
Screenshot 2024-12-08 at 1 13 37 AM
Screenshot 2024-12-08 at 1 13 59 AM
Screenshot 2024-12-08 at 1 16 20 AM
Screenshot 2024-12-08 at 1 16 41 AM

@psvenk
Copy link
Member

psvenk commented Dec 8, 2024

Looks good to me; thank you! I think this is ready to merge once highContrastDark is also updated accordingly.

@dtemkin1 dtemkin1 requested a review from psvenk December 13, 2024 16:27
@psvenk psvenk merged commit 1f03bd1 into sipb:main Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with high contrast themes
4 participants