-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#226 Update to allow for use of rtcp-mux where RTP is multiplexed with RTCP #227
base: master
Are you sure you want to change the base?
Conversation
Neil Hampton seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Not sure why, but sometimes when I run this after this change I get the following error after an RTCP message is detected: 2022/04/08 14:30:26.608643 hep.go:92: ERR write udp 10.202.118.101:42832->10.202.64.185:9060: write: message too long This doesn't happen on every run of heplify, but when it happens it is for every RTCP message and doesn't stop until I restart heplify. |
@kYroL01 can we merge ? |
@adubovikov not yet because I spotted a little bug and I need to test better. The PR is correct for that case but for default not, so I'm reverting a change that I think create the problem, do another full test and then we can merge |
No description provided.