Skip to content

fix: openrouter in providers and modellist length is greater than 0 #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yinwm merged 3 commits into from
Feb 26, 2026
Merged

fix: openrouter in providers and modellist length is greater than 0 #766

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81c8c07
fix:Openrouter in providers and modellist
penzhan8451 Feb 25, 2026
78ba057
Merge branch 'main' of https://github.com/sipeed/picoclaw
penzhan8451 Feb 26, 2026
a161bf9
Merge branch 'main' of https://github.com/sipeed/picoclaw
penzhan8451 Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions pkg/providers/legacy_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,21 @@ import (
func CreateProvider(cfg *config.Config) (LLMProvider, string, error) {
model := cfg.Agents.Defaults.GetModelName()

// Ensure model_list is populated (should be done by LoadConfig, but handle edge cases)
if len(cfg.ModelList) == 0 && cfg.HasProvidersConfig() {
cfg.ModelList = config.ConvertProvidersToModelList(cfg)
// Ensure model_list is populated from providers config if needed
// This handles two cases:
// 1. ModelList is empty - convert all providers
// 2. ModelList has some entries but not all providers - merge missing ones
if cfg.HasProvidersConfig() {
providerModels := config.ConvertProvidersToModelList(cfg)
existingModelNames := make(map[string]bool)
for _, m := range cfg.ModelList {
existingModelNames[m.ModelName] = true
}
for _, pm := range providerModels {
if !existingModelNames[pm.ModelName] {
cfg.ModelList = append(cfg.ModelList, pm)
}
}
Comment on lines +26 to +35
Copy link
Contributor

@yumosx yumosx Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
providerModels := config.ConvertProvidersToModelList(cfg)
existingModelNames := make(map[string]bool)
for _, m := range cfg.ModelList {
existingModelNames[m.ModelName] = true
}
for _, pm := range providerModels {
if !existingModelNames[pm.ModelName] {
cfg.ModelList = append(cfg.ModelList, pm)
}
}
providerModels := config.ConvertProvidersToModelList(cfg)
existing := make(map[string]struct{}, len(cfg.ModelList)+len(providerModels))
for _, m := range cfg.ModelList {
existing[m.ModelName] = struct{}{}
}
var toAdd []Model
for _, pm := range providerModels {
if _, ok := existing[pm.ModelName]; !ok {
toAdd = append(toAdd, pm)
existing[pm.ModelName] = struct{}{}
}
}
cfg.ModelList = append(cfg.ModelList, toAdd...)

Copy link
Contributor Author

@penzhan8451 penzhan8451 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yumosx It is ok for me.

}

// Must have model_list at this point
Expand Down