Skip to content

Commit

Permalink
minor detox fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
syuraj committed Sep 19, 2022
1 parent a3bad13 commit 535646f
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 66 deletions.
10 changes: 0 additions & 10 deletions .detoxrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,7 @@
"testRunner": "jest",
"runnerConfig": "e2e/config.json",
"skipLegacyWorkersInjection": true,
"apps": {
"android": {
"type": "android.apk",
"binaryPath": "android/app/build/outputs/apk/unsigned/debug/app-unsigned-debug.apk"
}
},
"configurations": {
"android": {
"device": "emulator",
"app": "android"
},
"android.emu.debug": {
"binaryPath": "android/app/build/outputs/apk/unsigned/debug/app-unsigned-debug.apk",
"build": "cd android && ./gradlew assembleUnsignedDebug assembleAndroidTest -DtestBuildType=debug && cd ..",
Expand Down
9 changes: 7 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ android {

proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
// Detox-specific additions to pro-guard
// proguardFile "${rootProject.projectDir}/../node_modules/detox/android/detox/proguard-rules-app.pro"
proguardFile "${rootProject.projectDir}/../node_modules/detox/android/detox/proguard-rules-app.pro"

firebaseCrashlytics {
nativeSymbolUploadEnabled true
Expand Down Expand Up @@ -110,6 +110,7 @@ android {
pickFirst "lib/arm64-v8a/libc++_shared.so"
pickFirst "lib/x86/libc++_shared.so"
pickFirst "lib/x86_64/libc++_shared.so"
pickFirst "META-INF/MANIFEST.MF"
}
}

Expand Down Expand Up @@ -144,8 +145,12 @@ dependencies {
implementation 'androidx.work:work-runtime:2.7.1'
implementation "androidx.media:media:1.6.0"

implementation 'androidx.appcompat:appcompat:1.5.1'

androidTestImplementation('com.wix:detox:0.1.1') { transitive = true }
androidTestImplementation 'junit:junit:4.12'
androidTestImplementation 'junit:junit:4.13.2'
androidTestImplementation "androidx.test:core:1.4.0"

implementation "androidx.annotation:annotation:1.4.0"
}

Expand Down

This file was deleted.

2 changes: 1 addition & 1 deletion android/app/src/debug/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
android:usesCleartextTraffic="true"
tools:targetApi="28"
tools:ignore="GoogleAppIndexingWarning">
<activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
<activity android:name="com.facebook.react.devsupport.DevSettingsActivity" android:exported="false"/>
</application>
</manifest>
9 changes: 8 additions & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ buildscript {
buildToolsVersion = '30.0.0'
minSdkVersion = 21
compileSdkVersion = 32
targetSdkVersion = 31
targetSdkVersion = 32
supportLibVersion = "28.0.0"
ndkVersion = "20.1.5948944"
kotlinVersion = '1.7.10'
}
repositories {
jcenter()
Expand All @@ -22,6 +23,8 @@ buildscript {
classpath 'com.google.gms:google-services:4.3.13'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.9.1'
classpath 'com.google.firebase:perf-plugin:1.4.1'

classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
}
}

Expand All @@ -42,6 +45,10 @@ allprojects {
// Android JSC is installed from npm
url("$rootDir/../node_modules/jsc-android/dist")
}
maven {
// All of Detox' artifacts are provided via the npm module
url "$rootDir/../node_modules/detox/Detox-android"
}

google()
jcenter()
Expand Down
2 changes: 2 additions & 0 deletions android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,7 @@ android.useAndroidX=true
# Automatically convert third-party libraries to use AndroidX
android.enableJetifier=true

android.useNewApkCreator=false

# Version of flipper SDK to use with React Native
FLIPPER_VERSION=0.162.0
17 changes: 0 additions & 17 deletions test.detoxrc.json

This file was deleted.

0 comments on commit 535646f

Please sign in to comment.