Bugfix/search #114
Merged
Bugfix/search #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acobster
force-pushed
the
bugfix/search
branch
from
a9137c5 to
ca72229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #108
Issue
SupportsAdvancedSearchcan trigger database errors in some cases, such as when running admin queries, or when custom clauses are added to the query (and thusmeta_keyis not a unique column).Solution
Detect edge cases and default settings to support (hopefully) all use-cases.
Impact
Stabilizes the search API.
Usage Changes
None.
Considerations
None.
Testing
Passes e2e tests (this isn't very unit-testable as-is).