Skip to content

Commit

Permalink
Issue #1958 - Check for android.enabled when checking debug mode. (#1959
Browse files Browse the repository at this point in the history
)
  • Loading branch information
gmierz authored Jun 18, 2023
1 parent 3234dd5 commit d9cd79d
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions lib/support/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ function validateInput(argv) {
}
}

// hack to keep backward compability to --android
if (argv.android[0] === true) {
set(argv, 'android.enabled', true);
}

if (argv.chrome && argv.chrome.mobileEmulation) {
const m = argv.chrome.mobileEmulation;
if (!(m.deviceName || (m.height && m.width && m.pixelRatio))) {
Expand All @@ -82,7 +87,7 @@ function validateInput(argv) {
return 'Debug mode do not work in Safari. Please try with Firefox/Chrome or Edge';
}

if (argv.debug && argv.android) {
if (argv.debug && argv.android.enabled) {
return 'Debug mode do not work on Android. Please run debug mode on Desktop.';
}

Expand Down Expand Up @@ -1262,10 +1267,6 @@ export function parseCommandLine() {

let argv = validated.argv;

// hack to keep backward compability to --android
if (argv.android[0] === true) {
set(argv, 'android.enabled', true);
}
if (
argv.firefox &&
(argv.firefox.nightly || argv.firefox.beta || argv.firefox.developer)
Expand Down

0 comments on commit d9cd79d

Please sign in to comment.