Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Chromedriver version that fixes the Mac issue. #1981

Closed
wants to merge 2 commits into from
Closed

New Chromedriver version that fixes the Mac issue. #1981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
780affd
New Chromedriver version that fixes the Mac issue.
soulgalore Aug 15, 2023
29eea9f
fix
soulgalore Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions lib/chrome/webdriver/setupChromiumOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { readFileSync } from 'node:fs';
import { platform } from 'node:os';
import intel from 'intel';
import { chromeDesktopOptions as defaultChromeOptions } from '../settings/chromeDesktopOptions.js';
import { chromeAndroidOptions as defaultAndroidChromeOptions } from '../settings/chromeAndroidOptions.js';
Expand Down Expand Up @@ -189,14 +188,6 @@ export function setupChromiumOptions(

if (browserOptions.binaryPath) {
seleniumOptions.setChromeBinaryPath(browserOptions.binaryPath);
} else {
// Fix for https://github.com/sitespeedio/browsertime/issues/1968
// Same settings for Chrome/Edge
if (options.browser === 'chrome' && platform() === 'darwin') {
seleniumOptions.setChromeBinaryPath(
'/Applications/Google Chrome.app/Contents/MacOS/Google Chrome'
);
}
}

if (browserOptions.mobileEmulation) {
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dependencies": {
"@cypress/xvfb": "1.2.4",
"@devicefarmer/adbkit": "2.11.3",
"@sitespeed.io/chromedriver": "115.0.5790-98b",
"@sitespeed.io/chromedriver": "115.0.5790-170",
"@sitespeed.io/edgedriver": "115.0.1901-183",
"@sitespeed.io/geckodriver": "0.33.0",
"@sitespeed.io/throttle": "5.0.0",
Expand Down