Expose trace start/stop #1988
Merged
Expose trace start/stop #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 11, 2023 22:14
|
Hi @92kns yes that would be cool. I'll have a look |
|
Oh sorry I forgot about this, let me have a look tonight. There were a couple small fixes but I can fix those. I haven't tried the functionality yet though :) |
|
no worries, sounds good! thanks :) |
|
Thank you @92kns ! I will do follow up PR with small refactoring, just so we don't have the same functionality twice. Thank you again! |
|
Awesome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'd like to expose the start/stop for the chrome Trace similar to how it was done with the gecko profiler in #1934 and #1940
Does the implementation here make sense?