Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the url from the result array in GeckoProfiler.stop #1999

Merged
merged 1 commit into from
Oct 13, 2023

Commits on Oct 12, 2023

  1. Get the url from the result array in GeckoProfiler.stop

    Previously for gecko profiler commands we were getting the test url by
    running a script that returns `document.documentURI`. This was working
    fine for most cases. But when one of our tests actually navigates to a
    different page from the starting page, it gets the destination url
    instead of the initial url. Since we need the initial url, it's better
    not to get the url like this, and get it directly from the `result`
    array.
    
    Note that chrome trace command does something similar [here](https://github.com/sitespeedio/browsertime/blob/e3e5a46f6c9070c0ab66e543b85e60d021edc848/lib/core/engine/command/chromeTrace.js#L42).
    canova committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    ef2c0f0 View commit details
    Browse the repository at this point in the history