Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRUX: Remove experimental from INP. #3906

Merged
merged 1 commit into from
Jul 15, 2023
Merged

CRUX: Remove experimental from INP. #3906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/plugins/crux/pug/index.pug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ mixin sizeCell(title, size)
td.number(data-title=title, data-value= size)= h.size.format(size)

- const crux = pageInfo.data.crux.pageSummary;
- const metrics = {first_contentful_paint:'First Contentful Paint (FCP)', largest_contentful_paint: 'Largest Contentful Paint (LCP)', first_input_delay:'First Input Delay (FID)', cumulative_layout_shift: 'Cumulative Layout Shift (CLS)',experimental_interaction_to_next_paint: 'Interaction to next paint (INP)', experimental_time_to_first_byte: 'Time to first byte (TTFB)'};
- const metrics = {first_contentful_paint:'First Contentful Paint (FCP)', largest_contentful_paint: 'Largest Contentful Paint (LCP)', first_input_delay:'First Input Delay (FID)', cumulative_layout_shift: 'Cumulative Layout Shift (CLS)', interaction_to_next_paint: 'Interaction to next paint (INP)', experimental_time_to_first_byte: 'Time to first byte (TTFB)'};
- const experiences = ['loadingExperience','originLoadingExperience'];

if experiences
Expand Down Expand Up @@ -69,7 +69,7 @@ if experiences

- let TTFBs = [Number(get(crux, `${cruxus}.experimental_time_to_first_byte.histogram[0].density`, 0) * 100).toFixed(2), Number(get(crux, `${cruxus}.experimental_time_to_first_byte.histogram[1].density`, 0) * 100).toFixed(2), Number(get(crux, `${cruxus}.experimental_time_to_first_byte.histogram[2].density`, 0)*100).toFixed(2)];

- let ITNPs = [Number(get(crux, `${cruxus}.experimental_interaction_to_next_paint.histogram[0].density`, 0) * 100).toFixed(2), Number(get(crux, `${cruxus}.experimental_interaction_to_next_paint.histogram[1].density`, 0) * 100).toFixed(2), Number(get(crux, `${cruxus}.experimental_interaction_to_next_paint.histogram[2].density`, 0)*100).toFixed(2)];
- let ITNPs = [Number(get(crux, `${cruxus}.interaction_to_next_paint.histogram[0].density`, 0) * 100).toFixed(2), Number(get(crux, `${cruxus}.interaction_to_next_paint.histogram[1].density`, 0) * 100).toFixed(2), Number(get(crux, `${cruxus}.interaction_to_next_paint.histogram[2].density`, 0)*100).toFixed(2)];

script(type='text/javascript').
document.addEventListener("DOMContentLoaded", function() {
Expand Down Expand Up @@ -114,12 +114,12 @@ if experiences
.ct-chart(id='chartFID' + experience + formFactor)
tr
th #{metrics['cumulative_layout_shift']}
th #{metrics['experimental_interaction_to_next_paint']}
th #{metrics['interaction_to_next_paint']}
th #{metrics['experimental_time_to_first_byte']}
tr
td(data-title=metrics['cumulative_layout_shift'])
.ct-chart(id='chartCLS' + experience + formFactor)
td(data-title=metrics['experimental_interaction_to_next_paint'])
td(data-title=metrics['interaction_to_next_paint'])
.ct-chart(id='chartITNP' + experience + formFactor)
td(data-title=metrics['experimental_time_to_first_byte'])
.ct-chart(id='chartTTFB' + experience + formFactor)
Expand Down
17 changes: 8 additions & 9 deletions lib/plugins/crux/repackage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,16 @@ export function repackage(cruxResult) {
};
}

if (cruxResult.record.metrics.experimental_interaction_to_next_paint) {
if (cruxResult.record.metrics.interaction_to_next_paint) {
result.INTERACTION_TO_NEXT_PAINT_MS = {
p75: cruxResult.record.metrics.experimental_interaction_to_next_paint
.percentiles.p75,
fast: cruxResult.record.metrics.experimental_interaction_to_next_paint
.histogram[0].density,
p75: cruxResult.record.metrics.interaction_to_next_paint.percentiles.p75,
fast: cruxResult.record.metrics.interaction_to_next_paint.histogram[0]
.density,
moderate:
cruxResult.record.metrics.experimental_interaction_to_next_paint
.histogram[1].density,
slow: cruxResult.record.metrics.experimental_interaction_to_next_paint
.histogram[2].density
cruxResult.record.metrics.interaction_to_next_paint.histogram[1]
.density,
slow: cruxResult.record.metrics.interaction_to_next_paint.histogram[2]
.density
};
}

Expand Down