Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on warning msg #4279

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Fix error on warning msg #4279

merged 2 commits into from
Sep 18, 2024

Conversation

roelvv
Copy link
Contributor

@roelvv roelvv commented Sep 17, 2024

Your checklist for a pull request to sitespeed.io

Please review the guidelines for contributing to this repository.

  • I'm making a big change or adding functionality so I've already opened an issue proposing the change to other contributors, so I got feedback on the idea before took the time to write precious code
  • Check that your change/fix has corresponding unit tests (if applicable)
  • Squash commits so it looks sane
  • Update the documentation https://github.com/sitespeedio/sitespeed.io/tree/main/docs in another PR
  • Verify that the test works by running npm test and test linting by npm run lint

Description

I ran into an error on this line while playing around with the compare plugin, where timestamps is undefined.

@soulgalore soulgalore merged commit 465e054 into sitespeedio:main Sep 18, 2024
7 of 9 checks passed
@soulgalore
Copy link
Member

Thank you @roelvv !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants