Feature/proto creation #4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,4 @@ | ||
| /vendor | ||
| __pycache__/ | ||
| /dion-env | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package clientwithoutinternode; | ||
|
|
||
| message GetRequest { | ||
| string key = 1; | ||
| } | ||
|
|
||
| message GetResponse { | ||
| string value = 1; | ||
| } | ||
|
|
||
| message PutRequest { | ||
| string key = 1; | ||
| string value = 2; | ||
| } | ||
|
|
||
| message PutResponse { | ||
|
Owner
There was a problem hiding this comment. should return key and value back to user as well |
||
| bool success = 1; | ||
| } | ||
|
|
||
| service KeyValueService { | ||
| rpc Get(GetRequest) returns (GetResponse); | ||
| rpc Put(PutRequest) returns (PutResponse); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| package server | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "sixletters/simple-db/pkg/storage" | ||
| "sixletters/simple-db/pkg/tree" | ||
| "sixletters/simple-db/pkg/stubs" | ||
| ) | ||
|
|
||
| type grpcServer struct{ | ||
| storageEngine storage.StorageEngine | ||
| } | ||
|
|
||
| func NewGrpcServer() *grpcServer { | ||
| newStorageConfig := storage.NewConfigWithOpts( | ||
|
Owner
There was a problem hiding this comment. see how its done in the http server, you dont build a new storage engine everytime, its a singleton that is shared between all servers, not an instance that is instantiated everytime |
||
| storage.WithTreeType(tree.BTree), | ||
|
Owner
There was a problem hiding this comment. see how its done in http server, all these are abstracted from the grpc server |
||
| storage.WithFilePath("testFile.txt"), | ||
|
|
||
| ) | ||
| storageEngine, err := storage.NewSingletonEngine(newStorageConfig) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| return &grpcServer{ | ||
| storageEngine: storageEngine, | ||
| } | ||
| } | ||
|
|
||
| func (s *grpcServer) Get(ctx context.Context, req *stubs.GetRequest) (*stubs.GetResponse, error) { | ||
| res, err := s.storageEngine.Get(context.Background(), req.Key) | ||
| if err != nil { | ||
| fmt.Print(err.Error()) | ||
| return nil, err | ||
| } | ||
| return &stubs.GetResponse{Value: res}, nil | ||
| } | ||
|
|
||
| func (s *grpcServer) Put(ctx context.Context, req *stubs.PutRequest) (*stubs.PutResponse, error) { | ||
| err := s.storageEngine.Put(context.Background(), req.Key, req.Value) | ||
| if err != nil { | ||
| fmt.Print(err.Error()) | ||
| return &stubs.PutResponse{Success: false}, err | ||
| } | ||
| return &stubs.PutResponse{Success: true}, nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package storage | ||
|
|
||
|
|
||
| import "context" | ||
|
|
||
| type StorageEngine interface { | ||
| Put(ctx context.Context, key string, value string) error | ||
| Get(ctx context.Context, key string) (string, error) | ||
| } | ||
|
|
||
| type storageEngine struct { | ||
| } | ||
|
|
||
| func NewStorageEngine() StorageEngine { | ||
| return &storageEngine{} | ||
| } | ||
|
|
||
| func (s *storageEngine) Put(ctx context.Context, key string, value string) error { | ||
| return nil | ||
| } | ||
|
|
||
| func (s *storageEngine) Get(ctx context.Context, key string) (string, error) { | ||
| return "", nil | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should return the key back to user as well