refactor: simple logic

siyul-park · Nov 22, 2023 · 50864f0 · 50864f0
1 parent 11dadeb
commit 50864f0
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/cmd/uniflow/apply/cmd.go b/cmd/uniflow/apply/cmd.go
@@ -115,11 +115,10 @@ func NewCmd(config Config) *cobra.Command {
 			for _, spec := range specs {
 				if util.IsZero(spec.GetID()) {
 					if spec.GetName() != "" {
-						exist, err := st.FindOne(ctx, storage.Where[string](scheme.KeyName).EQ(spec.GetName()).And(storage.Where[string](scheme.KeyNamespace).EQ(spec.GetNamespace())))
-						if err != nil {
+						filter := storage.Where[string](scheme.KeyName).EQ(spec.GetName()).And(storage.Where[string](scheme.KeyNamespace).EQ(spec.GetNamespace()))
+						if exist, err := st.FindOne(ctx, filter); err != nil {
 							return err
-						}
-						if exist != nil {
+						} else if exist != nil {
 							spec.SetID(exist.GetID())
 						}
 					} else {