refactor: process

siyul-park · Dec 1, 2023 · 8b9971a · 8b9971a
1 parent 46a2c47
commit 8b9971a
Show file tree

Hide file tree

Showing 11 changed files with 59 additions and 62 deletions.
diff --git a/pkg/node/onetomany_test.go b/pkg/node/onetomany_test.go
@@ -64,7 +64,7 @@ func TestOneToManyNode_Send(t *testing.T) {
 		outPort.Link(out)
 
 		proc := process.New()
-		defer proc.Close()
+		defer proc.Exit()
 
 		inStream := in.Open(proc)
 		outStream := out.Open(proc)
@@ -109,7 +109,7 @@ func TestOneToManyNode_Send(t *testing.T) {
 		errPort.Link(err)
 
 		proc := process.New()
-		defer proc.Close()
+		defer proc.Exit()
 
 		inStream := in.Open(proc)
 		errStream := err.Open(proc)

diff --git a/pkg/node/onetoone_test.go b/pkg/node/onetoone_test.go
@@ -65,7 +65,7 @@ func TestOneToOneNode_Send(t *testing.T) {
 			ioPort.Link(io)
 
 			proc := process.New()
-			defer proc.Close()
+			defer proc.Exit()
 
 			ioStream := io.Open(proc)
 
@@ -102,7 +102,7 @@ func TestOneToOneNode_Send(t *testing.T) {
 			errPort.Link(err)
 
 			proc := process.New()
-			defer proc.Close()
+			defer proc.Exit()
 
 			ioStream := io.Open(proc)
 			errStream := err.Open(proc)
@@ -142,7 +142,7 @@ func TestOneToOneNode_Send(t *testing.T) {
 			outPort.Link(out)
 
 			proc := process.New()
-			defer proc.Close()
+			defer proc.Exit()
 
 			inStream := in.Open(proc)
 			outStream := out.Open(proc)
@@ -188,7 +188,7 @@ func TestOneToOneNode_Send(t *testing.T) {
 			errPort.Link(err)
 
 			proc := process.New()
-			defer proc.Close()
+			defer proc.Exit()
 
 			inStream := in.Open(proc)
 			errStream := err.Open(proc)

diff --git a/pkg/plugin/controllx/snippet_test.go b/pkg/plugin/controllx/snippet_test.go
@@ -44,7 +44,7 @@ function main(inPayload: any): any {
 		ioPort.Link(io)
 
 		proc := process.New()
-		defer proc.Close()
+		defer proc.Exit()
 
 		ioStream := io.Open(proc)
 
@@ -80,7 +80,7 @@ function main(inPayload) {
 		ioPort.Link(io)
 
 		proc := process.New()
-		defer proc.Close()
+		defer proc.Exit()
 
 		ioStream := io.Open(proc)
 
@@ -114,7 +114,7 @@ function main(inPayload) {
 		ioPort.Link(io)
 
 		proc := process.New()
-		defer proc.Close()
+		defer proc.Exit()
 
 		ioStream := io.Open(proc)
 
@@ -146,7 +146,7 @@ function main(inPayload) {
 		ioPort.Link(io)
 
 		proc := process.New()
-		defer proc.Close()
+		defer proc.Exit()
 
 		ioStream := io.Open(proc)
 
@@ -185,7 +185,7 @@ function main(inPayload: any): any {
 
 		for i := 0; i < b.N; i++ {
 			proc := process.New()
-			defer proc.Close()
+			defer proc.Exit()
 
 			ioStream := io.Open(proc)
 
@@ -222,7 +222,7 @@ function main(inPayload) {
 
 		for i := 0; i < b.N; i++ {
 			proc := process.New()
-			defer proc.Close()
+			defer proc.Exit()
 
 			ioStream := io.Open(proc)
 
@@ -255,7 +255,7 @@ function main(inPayload) {
 
 		for i := 0; i < b.N; i++ {
 			proc := process.New()
-			defer proc.Close()
+			defer proc.Exit()
 
 			ioStream := io.Open(proc)
 
@@ -288,7 +288,7 @@ function main(inPayload) {
 
 		for i := 0; i < b.N; i++ {
 			proc := process.New()
-			defer proc.Close()
+			defer proc.Exit()
 
 			ioStream := io.Open(proc)
 

diff --git a/pkg/plugin/controllx/switch_test.go b/pkg/plugin/controllx/switch_test.go
@@ -79,7 +79,7 @@ func TestSwitchNode_Send(t *testing.T) {
 			outPort.Link(out)
 
 			proc := process.New()
-			defer proc.Close()
+			defer proc.Exit()
 
 			inStream := in.Open(proc)
 			outStream := out.Open(proc)

diff --git a/pkg/plugin/networkx/http.go b/pkg/plugin/networkx/http.go
@@ -394,13 +394,13 @@ func (n *HTTPNode) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	proc := process.New()
 	defer func() {
 		proc.Stack().Wait()
-		proc.Close()
+		proc.Exit()
 	}()
 
 	go func() {
 		select {
 		case <-r.Context().Done():
-			proc.Close()
+			proc.Exit()
 		case <-proc.Done():
 		}
 	}()

diff --git a/pkg/plugin/networkx/router_test.go b/pkg/plugin/networkx/router_test.go
@@ -71,7 +71,7 @@ func TestRouterNode_Send(t *testing.T) {
 			outPort.Link(out)
 
 			proc := process.New()
-			defer proc.Close()
+			defer proc.Exit()
 
 			inStream := in.Open(proc)
 			outStream := out.Open(proc)

diff --git a/pkg/plugin/systemx/reflect_test.go b/pkg/plugin/systemx/reflect_test.go
@@ -64,7 +64,7 @@ func TestReflectNode_Send(t *testing.T) {
 		ioPort.Link(io)
 
 		proc := process.New()
-		defer proc.Close()
+		defer proc.Exit()
 
 		ioStream := io.Open(proc)
 
@@ -108,7 +108,7 @@ func TestReflectNode_Send(t *testing.T) {
 		ioPort.Link(io)
 
 		proc := process.New()
-		defer proc.Close()
+		defer proc.Exit()
 
 		ioStream := io.Open(proc)
 
@@ -146,7 +146,7 @@ func TestReflectNode_Send(t *testing.T) {
 		ioPort.Link(io)
 
 		proc := process.New()
-		defer proc.Close()
+		defer proc.Exit()
 
 		ioStream := io.Open(proc)
 
@@ -190,7 +190,7 @@ func TestReflectNode_Send(t *testing.T) {
 		ioPort.Link(io)
 
 		proc := process.New()
-		defer proc.Close()
+		defer proc.Exit()
 
 		ioStream := io.Open(proc)
 

diff --git a/pkg/port/port_test.go b/pkg/port/port_test.go
@@ -94,7 +94,7 @@ func TestPort_Open(t *testing.T) {
 		proc := process.New()
 		stream := port.Open(proc)
 
-		proc.Close()
+		proc.Exit()
 
 		select {
 		case <-stream.Done():
@@ -105,7 +105,7 @@ func TestPort_Open(t *testing.T) {
 
 	t.Run("process closed", func(t *testing.T) {
 		proc := process.New()
-		proc.Close()
+		proc.Exit()
 
 		stream := port.Open(proc)
 

diff --git a/pkg/process/process.go b/pkg/process/process.go
@@ -6,15 +6,14 @@ import (
 	"github.com/oklog/ulid/v2"
 )
 
-type (
-	// Process is a processing unit that isolates data processing with others.
-	Process struct {
-		id    ulid.ULID
-		stack *Stack
-		done  chan struct{}
-		mu    sync.RWMutex
-	}
-)
+// Process is a processing unit that isolates data processing from others.
+
+type Process struct {
+	id    ulid.ULID
+	stack *Stack
+	done  chan struct{}
+	mu    sync.RWMutex
+}
 
 // New creates a new Process.
 func New() *Process {
@@ -26,29 +25,29 @@ func New() *Process {
 	}
 }
 
-// ID returns the ID.
+// ID returns the ID of the process.
 func (p *Process) ID() ulid.ULID {
 	p.mu.RLock()
 	defer p.mu.RUnlock()
 
 	return p.id
 }
 
-// Stack returns a Stack
+// Stack returns a process's stack.
 func (p *Process) Stack() *Stack {
 	p.mu.RLock()
 	defer p.mu.RUnlock()
 
 	return p.stack
 }
 
-// Done returns a channel that is closed when is closed.
+// Done returns a channel that is closed when the process is closed.
 func (p *Process) Done() <-chan struct{} {
 	return p.done
 }
 
-// Close closes the Process.
-func (p *Process) Close() {
+// Exit closes the process.
+func (p *Process) Exit() {
 	p.mu.Lock()
 	defer p.mu.Unlock()
 

diff --git a/pkg/process/process_test.go b/pkg/process/process_test.go
@@ -9,21 +9,21 @@ import (
 
 func TestNew(t *testing.T) {
 	proc := New()
-	defer proc.Close()
+	defer proc.Exit()
 
 	assert.NotNil(t, proc)
 }
 
 func TestProcess_ID(t *testing.T) {
 	proc := New()
-	defer proc.Close()
+	defer proc.Exit()
 
 	assert.NotEqual(t, ulid.ULID{}, proc.ID())
 }
 
 func TestProcess_Stack(t *testing.T) {
 	proc := New()
-	defer proc.Close()
+	defer proc.Exit()
 
 	assert.NotNil(t, proc.Stack())
 }
@@ -37,7 +37,7 @@ func TestProcess_Close(t *testing.T) {
 	default:
 	}
 
-	proc.Close()
+	proc.Exit()
 
 	select {
 	case <-proc.Done():